Skip to content

[F3-7] Update URL validation schemas and enhance modal functionality#31

Merged
dnishiyama merged 4 commits intodevfrom
fix/f3-7-field-verification-social-media
Apr 20, 2026
Merged

[F3-7] Update URL validation schemas and enhance modal functionality#31
dnishiyama merged 4 commits intodevfrom
fix/f3-7-field-verification-social-media

Conversation

@elsiedp
Copy link
Copy Markdown

@elsiedp elsiedp commented Mar 31, 2026

👋 TL;DR

  • Updated the AdminAOsModal to simplify query invalidation after updating AOs.
  • Introduced comprehensive URL validation schemas for website, Facebook, Instagram, and Twitter in the validators package.
  • Added tests for the new URL schemas to ensure proper validation of various URL formats.

🔎 Details

(coming soon)

✅ How to Test

(coming soon)

🥜 GIF

lack-of-hustle

@elsiedp elsiedp requested a review from dnishiyama as a code owner March 31, 2026 08:40
@makeplane
Copy link
Copy Markdown

makeplane Bot commented Mar 31, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@elsiedp elsiedp force-pushed the fix/f3-7-field-verification-social-media branch 2 times, most recently from f7878e7 to ab547ce Compare March 31, 2026 15:49
elsiedp added 3 commits April 14, 2026 12:54
- Updated the `AdminAOsModal` to simplify query invalidation after updating AOs.
- Introduced comprehensive URL validation schemas for website, Facebook, Instagram, and Twitter in the validators package.
- Added tests for the new URL schemas to ensure proper validation of various URL formats.
…book, and Instagram to include explicit TypeScript type definitions for the `field` parameter, enhancing type safety and clarity.
… improve clarity and validation logic, ensuring proper handling of optional URLs and enhancing user experience with more descriptive error messages.
@elsiedp elsiedp force-pushed the fix/f3-7-field-verification-social-media branch from ab547ce to 99b7df8 Compare April 14, 2026 04:55
@elsiedp
Copy link
Copy Markdown
Author

elsiedp commented Apr 14, 2026

the updates are the social fields in the admin portal

  • applies to all modals that have facebook, twiter, and instagram fields
image

Copy link
Copy Markdown

@dnishiyama dnishiyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dnishiyama dnishiyama merged commit 5cb3d17 into dev Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants